[FIX]factorize “the estimated predicted error covariance” #189
Open
Capsellab wants to merge 1 commit intorlabbe:masterfrom
Open
[FIX]factorize “the estimated predicted error covariance” #189Capsellab wants to merge 1 commit intorlabbe:masterfrom
Capsellab wants to merge 1 commit intorlabbe:masterfrom
Conversation
…rmula (43) in Measurement Update section.
rlabbe
requested changes
May 3, 2020
Owner
rlabbe
left a comment
There was a problem hiding this comment.
This does not run, as sigmas_f does not exist.
I suspect you meant to write this in the predict code:
sigmas = spherical_radial_sigmas(self.x, self.P)
# evaluate cubature points
for k in range(self._num_sigmas):
sigmas[k] = self.fx(sigmas[k], dt, *fx_args)
self.x, self.P = ckf_transform(sigmas, self.Q)
but am not sure. I haven't looked at cubature filters in a long time.
Ideal check ins include a new test (in the \tests subdirectory) that will fail on the old code, and pass on the new code, otherwise it is often impossible for me to really ascertain the effect of the change and whether it is valid or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You should factorize “the estimated predicted error covariance” on formula (43) , before "3)Evaluate the propagated cubature points" in the Measurement Update section.