Adds ability to find the expressionChainRoot#1517
Open
TwitchBronBron wants to merge 9 commits intomasterfrom
Open
Adds ability to find the expressionChainRoot#1517TwitchBronBron wants to merge 9 commits intomasterfrom
expressionChainRoot#1517TwitchBronBron wants to merge 9 commits intomasterfrom
Conversation
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes plugins need to find the expression at the top of the current chain. For example,
doSomething(alpha.beta.charlie)is represented in code asSo we want the outer
charlieDottedGetExpression because that's the one that is directly held by any parent statement. But in order to detect this, we need to understand ast boundaries, because.parentisn't enough since there's no notion of expression boundaries.This PR solves that, by providing a
.getExpressionChainRoot()function to find the root, or.isExpressionChainRootproperty on the node.