Skip to content

Conversation

@nicolasrochette
Copy link
Contributor

@nicolasrochette nicolasrochette commented Dec 18, 2025

This PR is to address issue #3899

Minor, but thanks again

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.26%. Comparing base (4c7c5c0) to head (607d394).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/readwrite.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3924   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files         117      117           
  Lines       12633    12633           
=======================================
  Hits         9887     9887           
  Misses       2746     2746           
Flag Coverage Δ
hatch-test.low-vers 77.59% <0.00%> (ø)
hatch-test.pre 77.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scanpy/readwrite.py 78.95% <0.00%> (ø)

@nicolasrochette nicolasrochette changed the title Now printing to log.debug (vs warning) when a file name comprises multiple dots (closes #3899) Fix: removed unecessary warning when a file name comprises multiple dots (closes #3899) Jan 30, 2026
@flying-sheep flying-sheep changed the title Fix: removed unecessary warning when a file name comprises multiple dots (closes #3899) fix: removed unecessary warning when a file name comprises multiple dots (closes #3899) Feb 10, 2026
@flying-sheep flying-sheep added this to the 1.12.1 milestone Feb 10, 2026
@flying-sheep flying-sheep changed the title fix: removed unecessary warning when a file name comprises multiple dots (closes #3899) fix: removed unecessary warning when a file name comprises multiple dots Feb 10, 2026
@flying-sheep flying-sheep merged commit 182d863 into scverse:main Feb 10, 2026
16 of 22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/scanpy that referenced this pull request Feb 10, 2026
@flying-sheep
Copy link
Member

thanks!

flying-sheep pushed a commit that referenced this pull request Feb 10, 2026
…hen a file name comprises multiple dots) (#3972)

Co-authored-by: nicolasrochette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

irrelevant warning in sc.readwrite.is_valid_filename

2 participants