-
Notifications
You must be signed in to change notification settings - Fork 863
fix: prevent nil pointer panic during pruning on shutdown #2801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v6.3
Are you sure you want to change the base?
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (38.27%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2801 +/- ##
================================================
- Coverage 43.36% 42.13% -1.23%
================================================
Files 1866 1465 -401
Lines 155305 114756 -40549
================================================
- Hits 67351 48356 -18995
+ Misses 81941 62285 -19656
+ Partials 6013 4115 -1898
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
539fec2 to
d9c1599
Compare
sei-db/ss/pebbledb/db.go
Outdated
|
|
||
| func (db *Database) Close() error { | ||
| // Mark as closed first to signal pruning to skip/return early | ||
| db.closed.Store(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should do a compare and swap and proceed if not closed already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point
Describe your changes and provide context
Testing performed to validate your change