Skip to content

Conversation

@blindchaser
Copy link
Contributor

Describe your changes and provide context

  • Remove redundant stateStore.Close() from HandleClose() since cms.Close() already handles it via rootmulti.Store.Close() -> ssStore.Close()
  • Add defensive nil checks in pebbledb/rocksdb Prune() methods to gracefully return error instead of panic if db is already closed

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 6, 2026, 5:13 AM

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.13%. Comparing base (97d1db2) to head (799d477).

❌ Your project check has failed because the head coverage (38.27%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.3    #2801      +/-   ##
================================================
- Coverage         43.36%   42.13%   -1.23%     
================================================
  Files              1866     1465     -401     
  Lines            155305   114756   -40549     
================================================
- Hits              67351    48356   -18995     
+ Misses            81941    62285   -19656     
+ Partials           6013     4115    -1898     
Flag Coverage Δ
sei-chain 42.55% <ø> (+0.01%) ⬆️
sei-cosmos 38.03% <ø> (+<0.01%) ⬆️
sei-db 69.39% <100.00%> (+24.46%) ⬆️
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint ?
sei-wasmd 41.57% <ø> (ø)
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 75.65% <ø> (+0.28%) ⬆️
sei-db/ss/rocksdb/db.go 59.44% <100.00%> (+0.64%) ⬆️

... and 407 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


func (db *Database) Close() error {
// Mark as closed first to signal pruning to skip/return early
db.closed.Store(true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do a compare and swap and proceed if not closed already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants