use system-filepath ro decode filename for file serve#152
Open
cvb wants to merge 4 commits intosnapframework:masterfrom
Open
use system-filepath ro decode filename for file serve#152cvb wants to merge 4 commits intosnapframework:masterfrom
cvb wants to merge 4 commits intosnapframework:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Me, again, I changed utf8-string to system-filepath, and as simplest solution, I use it to convert ByteString to System.IO.FilePath in getSafePath, because you still need path as string for System.Directory.
Is this enough or I should get rid of System.FilePath functions where it is posible?