Skip to content

Conversation

@infinityanant
Copy link

@infinityanant infinityanant commented Jan 16, 2026

Use this version to ensure the formatting is exactly how the maintainers expect it:

Refactor benchmarks to use the format utility for label generation instead of string concatenation. This ensures consistency with standard project benchmark naming conventions and facilitates future linting of benchmark names.

type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed

task: lint_editorconfig status: passed

task: lint_markdown status: na

task: lint_package_json status: na

task: lint_repl_help status: na

task: lint_javascript_src status: na

task: lint_javascript_cli status: na

task: lint_javascript_examples status: na

task: lint_javascript_tests status: na

task: lint_javascript_benchmarks status: passed

task: lint_python status: na

task: lint_r status: na

task: lint_c_src status: na

task: lint_c_examples status: na

task: lint_c_benchmarks status: na

task: lint_c_tests_fixtures status: na

task: lint_shell status: na

task: lint_typescript_declarations status: passed

task: lint_typescript_tests status: na

task: lint_license_headers status: passed

Resolves a part of #8647.

Description
This pull request:

Replaces manual string concatenation with the @stdlib/string/format utility in benchmarks for is-persymmetric-matrix, is-skew-centrosymmetric-matrix, is-skew-persymmetric-matrix, and is-square-matrix.

Adds the @stdlib/string/format import as demonstrated in the RFC.

Verifies that formatted benchmark names match the original names exactly to preserve existing behavior.

Related Issues
This pull request has no other related issues.

Questions
No.

Other
No.

Checklist

AI Assistance
[ ] Yes

[x] No

If you answered "yes" above, how did you use AI assistance?

[ ] Code generation

[ ] Test/benchmark generation

[ ] Documentation (including examples)

[ ] Research and understanding

Refactor benchmarks to use the format utility for label generation
instead of string concatenation. This ensures consistency with
standard project benchmark naming conventions.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Jan 16, 2026
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 16, 2026
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants