bench: refactor to use string interpolation in assert #9786
+24
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this version to ensure the formatting is exactly how the maintainers expect it:
Refactor benchmarks to use the format utility for label generation instead of string concatenation. This ensures consistency with standard project benchmark naming conventions and facilitates future linting of benchmark names.
type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report:
task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: na
task: lint_package_json status: na
task: lint_repl_help status: na
task: lint_javascript_src status: na
task: lint_javascript_cli status: na
task: lint_javascript_examples status: na
task: lint_javascript_tests status: na
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: na
task: lint_c_examples status: na
task: lint_c_benchmarks status: na
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: na
task: lint_license_headers status: passed
Resolves a part of #8647.
Description
This pull request:
Replaces manual string concatenation with the @stdlib/string/format utility in benchmarks for is-persymmetric-matrix, is-skew-centrosymmetric-matrix, is-skew-persymmetric-matrix, and is-square-matrix.
Adds the @stdlib/string/format import as demonstrated in the RFC.
Verifies that formatted benchmark names match the original names exactly to preserve existing behavior.
Related Issues
This pull request has no other related issues.
Questions
No.
Other
No.
Checklist
AI Assistance
[ ] Yes
[x] No
If you answered "yes" above, how did you use AI assistance?
[ ] Code generation
[ ] Test/benchmark generation
[ ] Documentation (including examples)
[ ] Research and understanding