Open
Conversation
Signed-off-by: Jiaming Lu <jiaming.lu@simplytyped.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need a
reverseScanso I implemented it.This PR added
scanmethods with aboolean reverseargument, and also a seperatereverseScanmethod.I exchanges the position of startKey and endKey before creating the iterator, because you did so in the rust client. I'm assuming startKey means strictly the lower bound and so does endKey.
Since there are no test cases for the behavior of
scanin this repo, unit tests forreverseScanare also not written.