Added multithreaded version of caching parser#24
Open
kyryloholodnov wants to merge 2 commits intoua-parser:masterfrom
Open
Added multithreaded version of caching parser#24kyryloholodnov wants to merge 2 commits intoua-parser:masterfrom
kyryloholodnov wants to merge 2 commits intoua-parser:masterfrom
Conversation
Author
|
Any update on this? |
douglaspalmer
suggested changes
Mar 9, 2023
Contributor
douglaspalmer
left a comment
douglaspalmer
left a comment
There was a problem hiding this comment.
After updating this PR it is good.
| } | ||
| }); | ||
|
|
||
| public ConcurrentCachingParser() throws IOException { |
Contributor
There was a problem hiding this comment.
Remove throws IOException
| public class ConcurrentCachingParserTest extends ParserTest { | ||
|
|
||
| @Before | ||
| public void initParser() throws Exception { |
Contributor
There was a problem hiding this comment.
Remove throws Exception
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>23.0</version> |
Contributor
There was a problem hiding this comment.
There's newer versions of this. Lets update to 31.1-jre
Contributor
|
@bpossolo Is there any chance of getting this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version is necessary for multithreaded environment. LRUMap from org.apache.commons.collections.map can hang in multithreaded production environment which is fully reproducible in high load.