Open
Conversation
Rhinowiwina
commented
Jul 4, 2021
Rhinowiwina
commented
* Add note about using cargo with private dependencies * Update doc to mention Windows only * Add alternative workaround * Create extra main section for tips and information regarding different languages/tools Co-authored-by: Matthias Pigulla <[email protected]>
…alled Co-authored-by: Shashank Patidar <[email protected]>
* Use SSH binaries from the Git suite * Try to kill the ssh-agent upon action termination on Windows as well
Resolves #68, closes #70, closes #71. Co-authored-by: Sean Killeen <[email protected]>
Resolves #69. Co-authored-by: Sean Killeen <[email protected]>
Co-authored-by: rr-james-hickman <[email protected]>
Co-authored-by: rr-james-hickman <[email protected]>
According to actions/runner#987, this should run the post step (cleanup.js) also when a workflow fails. Probably most important on self-hosted runners that are not ephemeral, to terminate SSH agents from failed jobs as well.
execSync just started a second ssh-agent. `['-k']` argument was treated as options, it didn't have `stdio` set, so stdio was piped and returned (and ignored).
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.