Skip to content

Better error logs when errors are hidden from the users#5000

Open
akshaymankar wants to merge 1 commit intodevelopfrom
better-error-logs
Open

Better error logs when errors are hidden from the users#5000
akshaymankar wants to merge 1 commit intodevelopfrom
better-error-logs

Conversation

@akshaymankar
Copy link
Member

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@akshaymankar akshaymankar requested review from a team as code owners February 3, 2026 15:53
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 3, 2026
pure . Left $
Wai.mkError status400 "client-error" "Invalid Request",
Handler $ \(_ :: TimeoutThread) ->
Handler $ \(_ :: TimeoutThread) -> do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This do is a bit suspicious. Have you forgotten to log the error here?

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants