Improve make_optional_func_list and make renegotiation functions opti…#43
Open
JacobBarthelmeh wants to merge 1 commit intowolfSSL:masterfrom
Open
Improve make_optional_func_list and make renegotiation functions opti…#43JacobBarthelmeh wants to merge 1 commit intowolfSSL:masterfrom
JacobBarthelmeh wants to merge 1 commit intowolfSSL:masterfrom
Conversation
…onal. `make_optional_func_list` will fall back to using `nm` to determine if a function is provided by libwolfssl if libwolfssl is a static library. This commit makes it so we first check if `nm` is available. If it's not available, the function will print a warning and assume all optional functions are available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onal.
make_optional_func_listwill fall back to usingnmto determine if a function is provided by libwolfssl if libwolfssl is a static library. This commit makes it so we first check ifnmis available. If it's not available, the function will print a warning and assume all optional functions are available.