SP ECC: ecc_point - add padding when 16 byte aligned#9634
Open
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Open
SP ECC: ecc_point - add padding when 16 byte aligned#9634SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@SparkiDev |
80815b8 to
48b8d0a
Compare
To make 16-byte aligned points, add padding to end.
48b8d0a to
38e8b94
Compare
douzzer
requested changes
Jan 9, 2026
Contributor
douzzer
left a comment
There was a problem hiding this comment.
alas, seeing the same failure as we've seen all along:
[ 2.346119] wolfssl: ecc_test_curve(): ecc_test_curve_size 66 failed!
[ 2.346878] wolfssl: ecc_test(): keySize=66, Default
[ 2.347464] wolfssl: wc_test_render_error_message(): ECC test failed!
[ 2.347464] error L=33348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To make 16-byte aligned points, add padding to end.
Testing
./configure --disable-shared --enable-sp --enable-sp-asm --enable-fpecc
./configure --disable-shared --enable-sp --enable-sp-asm --enable-fpecc CFLAGS=-DSP_ALIGN_16
Checklist