Conversation
784b100 to
db8e53a
Compare
db8e53a to
1895762
Compare
7470d91 to
3968669
Compare
Contributor
Author
|
jenkins retest this please |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Authority Information Access (AIA) handling to support multiple AIA entries per certificate and to expose CA Issuers URLs in addition to OCSP, with associated test certificates and API surface.
Changes:
- Introduces a shared
WOLFSSL_AIA_ENTRYrepresentation and stores multiple AIA locations (method + URI) inDecodedCertandWOLFSSL_X509, with overflow tracking and copying from decoded certs into X.509 objects. - Refactors AIA decoding in
wolfcrypt/src/asn.cand X.509 AIA accessors insrc/x509.cto build stacks of URIs for both OCSP and CA Issuers, while preserving legacy single-entry behavior as a fallback. - Adds tests, OpenSSL config, renewal script steps, and test certificates for CA Issuers AIA, multiple AIA entries, and overflow handling, and wires the new tests into the existing API test suite.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/wolfcrypt/asn.h | Defines WOLFSSL_AIA_ENTRY and adds extAuthInfoList, size, and overflow tracking to DecodedCert to represent multiple AIA entries per certificate. |
| wolfssl/ssl.h | Declares new public APIs wolfSSL_X509_get_aia_overflow and wolfSSL_X509_get1_ca_issuers alongside the existing OCSP AIA accessor. |
| wolfssl/internal.h | Mirrors the WOLFSSL_AIA_ENTRY struct and adds authInfoList, size, and overflow flags to WOLFSSL_X509 for runtime AIA storage. |
| wolfcrypt/src/asn.c | Extends DecodeAuthInfo (both template and non-template paths) to populate the AIA list, set the first OCSP and CA Issuer URIs, and flag overflows. |
| src/x509.c | Replaces the single-URI OCSP accessor with a generic AIA helper that returns stacks of URIs per method, adds an overflow query API, and adds a CA Issuers getter built on the same helper. |
| src/internal.c | Copies the decoded AIA list and overflow flag from DecodedCert into WOLFSSL_X509, rebasing URI pointers into the certificate’s DER buffer and enforcing WOLFSSL_MAX_AIA_ENTRIES. |
| tests/api.c | Adds tests for wolfSSL_X509_get1_ca_issuers, multi-entry OCSP/CA Issuers AIA URLs, and overflow behavior when the AIA list exceeds WOLFSSL_MAX_AIA_ENTRIES, and registers them in the test table. |
| certs/renewcerts/wolfssl.cnf | Adds OpenSSL config sections to generate AIA test certificates for CA Issuers, multiple AIA entries, and overflow cases. |
| certs/renewcerts.sh | Extends the renewal script to generate and refresh the new AIA test certificates used by the added tests. |
| certs/include.am | Ships the new AIA test certificates with the build/test distribution. |
| certs/crl/include.am | Adds additional CRL test files (large CRL number cases) to the distribution list. |
| certs/aia/*.pem | Provides concrete CA Issuers, multi-AIA, and overflow AIA certificates for exercising the new behavior in tests. |
| .gitignore | Ignores compile_commands.json to avoid checking in local code-navigation metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@padelsbach Can you look over the Copilot comment above and see if that is something you want to address in this PR? |
3968669 to
08c1397
Compare
cconlon
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
New unit tests
Checklist