SRTP-KDF: use two bytes of index #9733
Open
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
srtp_kdf_ctr_fix
branch
from
42d5a3c to
87b1c04
Compare
One byte of index creates up to 4096 bytes for a key. Increase output size to match specification.
SparkiDev
force-pushed
the
srtp_kdf_ctr_fix
branch
from
87b1c04 to
b1d3529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One byte of index creates up to 4096 bytes for a key. Increase output size to match specification.
Fixes zd#21139
Testing
./configure --disable-shared --enable-srtp-kdf
Added test to test.c that attempts to create keys larger than 4096 and checks they are different. Fails with old code and passes with new.
Checklist